Skip to content

Commit

Permalink
Update README to include JSON library
Browse files Browse the repository at this point in the history
  • Loading branch information
RainerKuemmerle committed Aug 18, 2024
1 parent a99d53c commit 24d1ffd
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,9 @@ following packages.

- spdlog <https://github.com/gabime/spdlog>
- suitesparse <http://faculty.cse.tamu.edu/davis/suitesparse.html>
- cereal <https://uscilab.github.io/cereal/index.html>
- Qt5 <http://qt-project.org>
- libQGLViewer <http://www.libqglviewer.com>
- JSON for Modern C++ <https://github.com/nlohmann/json>

On Ubuntu / Debian these dependencies are resolved by installing the
following packages.
Expand Down
5 changes: 1 addition & 4 deletions g2o/core/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,8 @@ set_target_properties(core PROPERTIES
SOVERSION ${G2O_LIB_SOVERSION})
target_link_libraries(core PUBLIC stuff Eigen3::Eigen)
target_link_libraries(core PUBLIC g2o_ceres_ad)
if (TARGET cereal::cereal)
target_link_libraries(core PUBLIC cereal::cereal)
endif()
if (TARGET nlohmann_json::nlohmann_json)
target_link_libraries(core PRIVATE nlohmann_json::nlohmann_json)
target_link_libraries(core PRIVATE nlohmann_json::nlohmann_json)
endif()
target_compile_features(core PUBLIC cxx_std_17)

Expand Down
2 changes: 1 addition & 1 deletion g2o/core/io/io_wrapper_json.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ NLOHMANN_DEFINE_TYPE_NON_INTRUSIVE(AbstractGraph::AbstractEdge, tag, ids,
namespace json {

/**
* @brief Versions of the IO API for the graph using cereal.
* @brief Versions of the IO API for the graph. Currently not stored.
*/
enum class IoVersions {
kGraph = 0,
Expand Down

0 comments on commit 24d1ffd

Please sign in to comment.