Pymem fileformat #753
Merged
Pymem fileformat #753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RainerKuemmerle
force-pushed
the
pymem-fileformat
branch
from
99f66ee to
cfe77b6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## pymem #753 +/- ##
===========================================
+ Coverage 53.27% 63.96% +10.68%
===========================================
Files 264 231 -33
Lines 10284 9272 -1012
===========================================
+ Hits 5479 5931 +452
+ Misses 4805 3341 -1464 ☔ View full report in Codecov by Sentry. |
RainerKuemmerle
force-pushed
the
pymem-fileformat
branch
3 times, most recently
from
95500af to
00c98b2
Compare
RainerKuemmerle
force-pushed
the
pymem-fileformat
branch
from
24691ab to
d06108b
Compare
RainerKuemmerle
force-pushed
the
pymem-fileformat
branch
from
584e6fb to
111b058
Compare
* Depend on cereal for serialization into several formats * Add JSON for AbstractGraph
* This drops API for read/write which should now be handled by traits.
Drop fstream functions
- Dropping setToOrigin - Drop Identity from TypeTraits
* implement a type based fixture that tests the IO of fixed size edges
* The implemented analytic Jacobian computes wrong values.
This might help to discover tests on Windows correctly.
Some of them are failing, the ones depending on parameters, and it requires debugging to figure out why this is the case.
EdgeSE2TwoPointsXY and EdgeSE2PointXYCalib are now derived from BaseFixedSizeEdge instead of variable size. They have been hardcoded to three vertices internally.
The base class type was missing after using the fixed sized edge as base class for some types.
RainerKuemmerle
force-pushed
the
pymem-fileformat
branch
from
111b058 to
06c57fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.