Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pymen def info #765

Merged
merged 3 commits into from
Feb 25, 2024
Merged

Pymen def info #765

merged 3 commits into from
Feb 25, 2024

Conversation

RainerKuemmerle
Copy link
Owner

For fixed size edges the ctor of the edge now initializes the matrix to
the Identity matrix. This simplifies creation of "standard" optimization
problems and seems less prone to errors causing undefined behavior.
The library should by default not write data.
We here change the behavior but give the user the chance to actively
activating writing of debug data if desired.
Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 53.27%. Comparing base (cb0b638) to head (fb3d3e2).

Files Patch % Lines
g2o/core/base_edge.h 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            pymem     #765      +/-   ##
==========================================
+ Coverage   53.22%   53.27%   +0.05%     
==========================================
  Files         264      264              
  Lines       10279    10284       +5     
==========================================
+ Hits         5471     5479       +8     
+ Misses       4808     4805       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RainerKuemmerle RainerKuemmerle merged commit ace2d98 into pymem Feb 25, 2024
6 of 7 checks passed
@RainerKuemmerle RainerKuemmerle deleted the pymen-defInfo branch February 25, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant