Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cooking Measurement Calculator #1600

Closed
wants to merge 6 commits into from

Conversation

codercake
Copy link

@codercake codercake commented Jul 10, 2024

Fixes Issue🛠️

Closes #1463

Description👨‍💻

This tool is particularly useful for recipes that require precise measurements and for those who need to convert between different units of weight commonly used in cooking.

Type of Change📄

  • New feature (non-breaking change which adds functionality)

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project

Screenshots/GIF📷

HOME PAGE:

Screenshot 2024-07-15 173205

WORKING DEMONSTRATION:

image

Copy link

netlify bot commented Jul 10, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 50cf632
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/669ba4377e38dc00087c0923
😎 Deploy Preview https://deploy-preview-1600--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @codercake, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

@Nihal4777
Copy link

@codercake Add you calc in main index.html file in alphabetical order. Also add empty field validations.
image

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Jul 12, 2024
@codercake
Copy link
Author

could you review the PR? @Nihal4777 @Rakesh9100

@Rakesh9100
Copy link
Owner

Attach the HOME PAGE: and WORKING DEMONSTRATION: in the PR description nicely @codercake

@codercake
Copy link
Author

Attach the HOME PAGE: and WORKING DEMONSTRATION: in the PR description nicely @codercake

done! @Rakesh9100

@codercake
Copy link
Author

can you check the updated changes made to pr? @Rakesh9100

@Nihal4777
Copy link

@codercake You shouldn't add images from other sources. Instead you can download it and save in assets folder.
image

@codercake
Copy link
Author

done! @Nihal4777

@Rakesh9100
Copy link
Owner

Are you assigned to the issue, no right? The mentor asked you a question there but you have still not answered that @codercake

Also, in issue you have mentioned these (e.g., cups to grams, tablespoons to milliliters) but only Ounces and Pounds are there!

@Rakesh9100 Rakesh9100 closed this Aug 7, 2024
@Rakesh9100 Rakesh9100 removed the question 🤔 Further information is requested label Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add Cooking Measurement Calculator
3 participants