Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Enhancement: Added Support for Feet Input in convertFeetToCm Function #1850

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

isid555
Copy link

@isid555 isid555 commented Aug 14, 2024

#1862

Description👨‍💻

This PR enhances the functionality of the convertFeetToCm function by adding support for feet input. Previously, the function only accepted centimeter (cm) values, limiting its flexibility. With this update, users can now input a value in feet, and the function will convert it to total centimeters.

Changes Made:

  • Modified the convertFeetToCm function to accept and correctly convert feet input to total centimeters.
  • Maintained the existing functionality for handling centimeter (cm) inputs.

This enhancement improves the utility of the function, making it more versatile for users who need to work with feet measurements.

Checklist✅

  • I am an Open Source contributor
  • I have performed a self-review of my code
  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas

Screenshots/GIF📷

Impact before changes

image

Impact after changes

BMI in cm

image

BMI in feet

image

Impact:

This enhancement provides greater flexibility in the function's usage, allowing users to perform more complex conversions in a single function call. It ensures that the function can now handle both feet and additional centimeters seamlessly

Request for Review:

Please review the changes to ensure they align with the expected functionality and coding standards. Feedback or suggestions for improvement are welcome.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @isid555, Welcome to the project CalcDiverse! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Aug 14, 2024

Deploy Preview for calcdiverse ready!

Name Link
🔨 Latest commit 49bb4ea
🔍 Latest deploy log https://app.netlify.com/sites/calcdiverse/deploys/66be3d37ef2a970008b91f10
😎 Deploy Preview https://deploy-preview-1850--calcdiverse.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@isid555
Copy link
Author

isid555 commented Aug 14, 2024

@Rakesh9100 Kindly review my contribution

@isid555 isid555 changed the title Issue Title: Enhance convertFeetToCm Function to Include Centimeter… Feature Enhancement: Added Support for Feet Input in convertFeetToCm Function Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant