Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added transition for the instruction box #255

Merged
merged 10 commits into from
Feb 6, 2024

Conversation

antilneeraj
Copy link
Contributor

Fixes Issue🛠️

Description👨‍💻

Added Transition to the instruction box when clicked on the instruction button and also added a cross button to close the modal.

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)

How this has been tested✅

I have tested the changes Locally using alpha, beta & unit testing.

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

image
image

Copy link

netlify bot commented Feb 5, 2024

Deploy Preview for click-the-edible-game ready!

Name Link
🔨 Latest commit 843dbe0
🔍 Latest deploy log https://app.netlify.com/sites/click-the-edible-game/deploys/65c277212df123000806243d
😎 Deploy Preview https://deploy-preview-255--click-the-edible-game.netlify.app/assets/main
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@antilneeraj
Copy link
Contributor Author

@Rakesh9100 The PR is ready for a review and merge. Kindly review it and provide your feedback

@Rakesh9100
Copy link
Owner

No need to change the UI. You have to just add transitions while opening and closing the box. Cross button added is OK.

In addition if you want, you can work on making it translucent for good looking but without changing the UI @antilneeraj

@Rakesh9100 Rakesh9100 changed the title [ISSUE - 200] Add transition for the instruction box Added transition for the instruction box Feb 5, 2024
@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 6, 2024
@antilneeraj
Copy link
Contributor Author

Hey @Rakesh9100 I have applied the animation to the modal without changing any UI Component. Please Review the PR and share your feedback

@Rakesh9100
Copy link
Owner

The 2nd and 3rd screens instruction box is not appearing on clicking the Instruction button, pls fix @antilneeraj

@antilneeraj
Copy link
Contributor Author

antilneeraj commented Feb 6, 2024

Hey @Rakesh9100, Please review the PR as i have fixed the modal issue and kindly provide your feedback.

@Rakesh9100
Copy link
Owner

Good, Merged 🎉 @antilneeraj

@Rakesh9100 Rakesh9100 merged commit 7e6804a into Rakesh9100:main Feb 6, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Completed 🥳 PR successfully merged and issue resolved on completion Medium IWOC2k24 (30 Points) ✨, JWOC2k24 (3 Points) 🎉, SWOC2k24 Level-2 (30 Points) 💫 JWOC JWOC 2k24Open Source Program and removed question 🤔 Further information is requested labels Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion JWOC JWOC 2k24Open Source Program Medium IWOC2k24 (30 Points) ✨, JWOC2k24 (3 Points) 🎉, SWOC2k24 Level-2 (30 Points) 💫
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Add transition for the instruction box
2 participants