-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #64 #65
base: master
Are you sure you want to change the base?
Closes #64 #65
Conversation
$B = 'fail'; | ||
print "$A "; | ||
print "$B "; | ||
say $result; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not computing $result. It will have the same value as before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sir should I have to create another pull request to commit required changes or please guide me how to create changes in this one? Sorry for inconvenience from my side @JJ
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You just have to push the changes to your original branch and they'll show up here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check my comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to make the required changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed Typo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still some things you need to do.
# for all the basic logic gates. | ||
|
||
multi and ($input1, $input2) { | ||
if $input1 eq 'true' && $input2 eq 'true' { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
multi defines subroutines as a side effect, but its main purpose, as it should, is to define multiple-schedule routines. Please check this, for instance, on how to define a subroutine.
Also, I don't really get why you are defining a new and that works on strings, when and working on Booleans is perfectly fine. If you want the exact symbols (true instead of true) then enum MyBoolean ( true => 1, false => 0 )
will allow you to work with existing and/or
say $result; | ||
|
||
$B = 'fail'; | ||
print "$A "; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should do something with $B after giving it a value.
No description provided.