Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #64 #65

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Closes #64 #65

wants to merge 3 commits into from

Conversation

veb7vmehra
Copy link

No description provided.

$B = 'fail';
print "$A ";
print "$B ";
say $result;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are not computing $result. It will have the same value as before.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sir should I have to create another pull request to commit required changes or please guide me how to create changes in this one? Sorry for inconvenience from my side @JJ

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You just have to push the changes to your original branch and they'll show up here.

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check my comments.

Copy link
Author

@veb7vmehra veb7vmehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to make the required changes

Copy link
Author

@veb7vmehra veb7vmehra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed Typo

Copy link
Contributor

@JJ JJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some things you need to do.

# for all the basic logic gates.

multi and ($input1, $input2) {
if $input1 eq 'true' && $input2 eq 'true' {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

multi defines subroutines as a side effect, but its main purpose, as it should, is to define multiple-schedule routines. Please check this, for instance, on how to define a subroutine.
Also, I don't really get why you are defining a new and that works on strings, when and working on Booleans is perfectly fine. If you want the exact symbols (true instead of true) then enum MyBoolean ( true => 1, false => 0 ) will allow you to work with existing and/or

say $result;

$B = 'fail';
print "$A ";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should do something with $B after giving it a value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants