Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify signals available to getsignals on WIN32 #465

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jstuder-gh
Copy link
Contributor

JS:
All the signals we need for Windows are actually already defined in
os.constants.signals

JVM:
Match getsignals JVM with MoarVM/JS backends

All the signals we need for Windows are actually already defined in
os.constants.signals
The following signals are defined on the MoarVM and JS backends.
@jstuder-gh jstuder-gh requested review from usev6 and pmurias June 11, 2018 20:31
@coke coke added the Windows Issues specifically impacting Windows label May 21, 2020
@usev6
Copy link
Contributor

usev6 commented May 21, 2020

@jstuder-gh sorry I've missed your request for a review back in 2018. I don't use Windows, but as far as I can see, adding the signals to sigWanted on the JVM backend increases consistency and looks sensible. nqp::getsignals will return negative values for all the not supported signals anyway, right? I can't comment on the changes to the JS backend.

The merge conflict stems from renaming s/perl6/raku/ earlier today (#630). It shouldn't be hard to resolve -- the changes need probably just copied over to the new location src/vm/jvm/runtime/org/raku/nqp/runtime/IOOps.java.

@coke coke changed the base branch from master to main April 19, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Windows Issues specifically impacting Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants