[JVM] Reimplement nqp::encode for utf-16 #749
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting from the bug reported in Raku#250 it turned out that the old implementation gave different results than MoarVM for all buffer types (at least in some cases). The new code doesn't try to take shortcuts, but just works through all code points one by one, translates them to UTF-16 code points and puts those into the result buffer. I'd guess at least the encodeUTF32 method needs a similar rework.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting from the bug reported in #250
it turned out that the old implementation gave different results than
MoarVM for all buffer types (at least in some cases). The new code
doesn't try to take shortcuts, but just works through all code points
one by one, translates them to UTF-16 code points and puts those into
the result buffer.
I'd guess at least the encodeUTF32 method needs a similar rework.