feat: Template refactor #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update libraries, solve shop swagger pointing at bestiary, sort result of listing trait and source
…to specific set of quantities for each template
…ms becomes 100% of 40). add tests
…mplate percentages
…d traits to template_data for future-proofing
…ist template, remove unique items from default templates
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…ype of template endpoint
TheAsel
previously approved these changes
Oct 2, 2024
RakuJa
dismissed stale reviews from TheAsel and github-actions[bot]
The base branch was changed.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new and better implementation of Shop Templates.
Before:
We had templates that were just an abstraction layer over different "ratios" of items. This meant that a "Alchemist" did not have a specific query associated with item properties but just ratio of "a lot of equipment and consumables, few or none armor,shields, weapons". As such, there was no possibility to express a more in-depth shop or to allow users to customize it.
Now:
This implementation is split into two main features: