Add statefulset and daemonset samples #41
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirs
force-pushed
the
statefulset
branch
2 times, most recently
from
0c8b7df
to
69c7a85
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2 tasks
nirs
force-pushed
the
statefulset
branch
2 times, most recently
from
b0b2dd2
to
f40c24f
Compare
nirs
force-pushed
the
statefulset
branch
2 times, most recently
from
b748df9
to
0cd51d1
Compare
nirs
requested review from
ShyamsundarR,
raghavendra-talur,
netzzer and
ELENAGER
This was referenced Nov 16, 2023
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
nirs
added a commit
to nirs/ocm-kubevirt-samples
that referenced
this pull request
Nov 30, 2023
Similar to ocm-ramen-sample PR[1] move the channel into the subscription kustomization. This is better for users, removing setup and teardown from the deployment steps. Now it is not possible to forget to deploy or remove the channel after testing. This is better for developers, since now we can test multiple VMs concurrently, without dealing with setup and cleanup of shared resources, since VMs do not share the channel. [1] RamenDR/ocm-ramen-samples#41
nirs
added a commit
to nirs/ocm-kubevirt-samples
that referenced
this pull request
Nov 30, 2023
Similar to ocm-ramen-sample PR[1] move the channel into the subscription kustomization. This is better for users, removing setup and teardown from the deployment steps. Now it is not possible to forget to deploy or remove the channel after testing. This is better for developers, since now we can test multiple VMs concurrently, without dealing with setup and cleanup of shared resources, since VMs do not share the channel. [1] RamenDR/ocm-ramen-samples#41
nirs
added a commit
to nirs/ocm-kubevirt-samples
that referenced
this pull request
Jan 15, 2024
Similar to ocm-ramen-sample PR[1] move the channel into the subscription kustomization. This is better for users, removing setup and teardown from the deployment steps. Now it is not possible to forget to deploy or remove the channel after testing. This is better for developers, since now we can test multiple VMs concurrently, without dealing with setup and cleanup of shared resources, since VMs do not share the channel. [1] RamenDR/ocm-ramen-samples#41
2 tasks
Each sample has a: - workload that can be used later for testing discovered apps - subscription kustomization that can be used manual testing or with ramen basic-test - dr kustomization that can be used manually (ramen basic-test generated its own drpc) Unfinished: - Not test yet - Need to add dr samples for discovered apps Signed-off-by: Nir Soffer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested yet, need samples for discovered apps.