Skip to content

Commit

Permalink
Improve generated resource names and logs
Browse files Browse the repository at this point in the history
- Use `{name}-drpc` instead of `busybox-drpc`
- Remove hard-coded 'busybox example' in logs
- Add application name to deploy/undeploy logs

Signed-off-by: Nir Soffer <[email protected]>
  • Loading branch information
nirs committed Nov 16, 2023
1 parent 6946abb commit 6eaa02f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions test/basic-test/undeploy
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ from drenv import test
test.start("undeploy", __file__)
args = test.parse_args()

test.info("Deleting busybox example application")
test.info("Deleting application")
test.undeploy()
test.info("Application was undeployed successfully")
test.info("Application was deleted")
6 changes: 3 additions & 3 deletions test/drenv/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def deploy():
"""
Deploy application on cluster.
"""
info("Deploying application")
info("Deploying application '%s'", config["name"])
kubectl.apply(
f"--kustomize={config['repo']}/{config['path']}?ref={config['branch']}",
context=env["hub"],
Expand All @@ -183,7 +183,7 @@ def undeploy():
"""
Undeploy an application.
"""
info("Undeploying application")
info(f"Undeploying application '%s'", config["name"])
kubectl.delete(
f"--kustomize={config['repo']}/{config['path']}?ref={config['branch']}",
"--ignore-not-found",
Expand Down Expand Up @@ -216,7 +216,7 @@ def enable_dr():
apiVersion: ramendr.openshift.io/v1alpha1
kind: DRPlacementControl
metadata:
name: busybox-drpc
name: {config['name']}-drpc
namespace: {config['namespace']}
labels:
app: {config['name']}
Expand Down

0 comments on commit 6eaa02f

Please sign in to comment.