Update recipe CRD to match with other consumers #35
+308
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are replaced by a list of workflows. The workflow names * backup * restore have special meaning. They will be used by default backup/capture and restore/recover workflow. Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
This allows for selection of namespaces by a label selector. Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
When set, this allows for restoring of the status section in the CRs. Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
When set, the resources are overwritten when a restore is being performed. Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
This is in preparation to introduction of other type of hooks. Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
This is for compatibility with other consumers of recipes. Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
This is for compatibility with other consumers of recipes. Signed-off-by: Raghavendra Talur <[email protected]> Co-Authored-by: Jose A. Rivera <[email protected]>
Signed-off-by: Raghavendra Talur <[email protected]>
raghavendra-talur
force-pushed
the
rtalur-update-recipe-api
branch
from
f9fcf2d
to
154ee1e
Compare
|
LGTM, will wait for other reviews and merge as appropriate. |
asn1809
reviewed
Sep 17, 2024
| // List of namespaces to include. | ||
| //+optional | ||
| IncludedNamespaces []string `json:"includedNamespaces,omitempty"` | ||
| // List of namespace to exclude | ||
| ExcludedNamespaces []string `json:"excludedNamespaces,omitempty"` |
There was a problem hiding this comment.
Can we also add excludedNamespacesByLabel?
There was a problem hiding this comment.
We thought about it, but given that other consumers haven't implemented a excludedNamespacesByLabel it could be that there's no demand for it, or that there exist other complications that are not immediately apparent before attempting implementation. Given that it's always easier to add rather than remove fields from an API, it feels prudent to leave it out until there's an explicit request for it.
There was a problem hiding this comment.
In this PR I am only trying to match the CRD with other consumers expectations. We can add other features in a subsequent PR.
ShyamsundarR
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several modifications to the API to have better compatibility with other consumers of the recipe CRD. The key changes include:
Command and Timeout Changes:
commandis now a single string format to improve compatibility with external recipe consumers.timeoutfield has been changed to an integer type for better consistency.Hooks Enhancements:
namespacefield mandatory for hooks.Group Configuration Updates:
RestoreOverwriteResources: Allows resource overwriting during restores.RestoreGroupStatus: Enables status section restoration in Custom Resources (CRs).ExcludedNamespaces: Specifies namespaces to be excluded during operations.IncludedNamespacesByLabel: Supports namespace selection based on label selectors.Workflow Improvements:
backupandrestore, which are now associated with default operations.Additional Changes:
Co-authorship: This pull request includes contributions from Jose A. Rivera.