-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] - Kubeconfig merge needs user and cluster #59
Conversation
#[derive(Default, Clone, PartialEq, Debug, Serialize, Deserialize)] | ||
pub struct Users { | ||
#[serde(default)] | ||
pub user: HashMap<String, Value>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using hashmap here because we aren't interested in the structure and they can vary from providers (AWS,k3s,GKE)
Hi, thanks for adding me as a reviewer 😊 I'm quite busy this week but I'll have a look this Saturday! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't quite manage Saturday 😅 I had a look and compared the generated cached kubeconfigs with and without the change, definitely a good step to make it possible to use them independently 👍
Code changes also look completely solid!
Ive been running with this for a while and only noticed one issue, the kcd command doesn't permanently set it, I'm guessing it's because the merged files isn't known to kubectl. |
This isn't needed anymore thanks to this: #60 |
Description
When merging and not using kubeconfig env variable, the resulting cached files don't have cluster and user in them.
This PR adds those so they can be more complete.
Results:
Fixes # (issue)
#46 Fixes part of this
Type of change
How Has This Been Tested?
Tested locally by using it for a while