Include path in the error message #267
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When returning an error message from the `cf_image_load_png` and `cf_image_load_png_indexed`, let's include the path that was problematic, so it's faster to identify the problem.
|
This does leak memory so can't merge it in as-is. I do agree the error reporting isn't quite sufficient here, but we can't just allocate a string like that and return it. |
|
The path is known by the caller right? Can't the caller just check the error and log accordingly? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning an error message from the
cf_image_load_pngandcf_image_load_png_indexed, let's include the path that was problematic, so it's faster to identify the problem.