Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested changes #843

Open
wants to merge 18 commits into
base: master
Choose a base branch
from
4 changes: 2 additions & 2 deletions data/items/names.asm
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ endc
li "Smoke Ball"
li "Berserk Gene"
li "Light Ball"
li "Stick"
li "Leek"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need rearranging alphabetically, and renaming the constants+labels.

li "Thick Club"
li "Lucky Punch"
li "Metal Powder"
Expand Down Expand Up @@ -226,7 +226,7 @@ endc
li "Power Band"
li "Power Anklet"
li "Dragon Scale"
li "Up-Grade"
li "Upgrade"
li "Dubious Disc"
li "Protector"
li "Electirizer"
Expand Down
3 changes: 3 additions & 0 deletions data/moves/descriptions.asm
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,9 @@ WillOWispDescription:

StunSporeDescription:
ThunderWaveDescription:
db "A move that"
next "paralyzes the foe.@"

GlareDescription:
db "A move that may"
next "paralyze the foe.@"
Expand Down
12 changes: 6 additions & 6 deletions maps/CherrygrovePokeCenter1F.asm
Original file line number Diff line number Diff line change
Expand Up @@ -44,18 +44,18 @@ CherrygrovePokeCenter1FTeacherScript:
iftrue_jumptextfaceplayer .Text2
jumpthistextfaceplayer

text "The Communication"
line "Center upstairs"
cont "was just built."
text "The Cable Club"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HGSS also calls it the Communication Center.

line "upstairs was"
cont "just built."

para "But they're still"
line "finishing it up."
done

.Text2:
text "The Communication"
line "Center upstairs"
cont "was just built."
text "The Cable Club"
line "upstairs was"
cont "just built."

para "I traded #mon"
line "there already!"
Expand Down
2 changes: 1 addition & 1 deletion maps/SoulHouse.asm
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ SoulHouse_MapScriptHeader:

def_object_events
object_event 9, 7, SPRITE_AGATHA, SPRITEMOVEDATA_STANDING_UP, 0, 0, -1, -1, 0, OBJECTTYPE_SCRIPT, 0, AgathaScript, -1
object_event 4, 2, SPRITE_GRAMPS, SPRITEMOVEDATA_STANDING_DOWN, 0, 0, -1, -1, PAL_NPC_BLUE, OBJECTTYPE_COMMAND, jumptextfaceplayer, MrFujiText, -1 ; TODO: EVENT_SOUL_HOUSE_MR_FUJI
object_event 4, 2, SPRITE_ELDER, SPRITEMOVEDATA_STANDING_DOWN, 0, 0, -1, -1, PAL_NPC_BLUE, OBJECTTYPE_COMMAND, jumptextfaceplayer, MrFujiText, -1 ; TODO: EVENT_SOUL_HOUSE_MR_FUJI
itsdarsh marked this conversation as resolved.
Show resolved Hide resolved
object_event 7, 3, SPRITE_POKEFAN_F, SPRITEMOVEDATA_WALK_LEFT_RIGHT, 0, 1, -1, -1, PAL_NPC_BLUE, OBJECTTYPE_COMMAND, jumptextfaceplayer, SoulHouseTeacherText, -1
object_event 2, 7, SPRITE_CUTE_GIRL, SPRITEMOVEDATA_STANDING_UP, 0, 0, -1, -1, PAL_NPC_BLUE, OBJECTTYPE_COMMAND, jumptextfaceplayer, SoulHouseLassText, -1
object_event 1, 5, SPRITE_GRANNY, SPRITEMOVEDATA_STANDING_UP, 0, 0, -1, -1, PAL_NPC_BLUE, OBJECTTYPE_COMMAND, jumptextfaceplayer, SoulHouseGrannyText, -1
Expand Down
2 changes: 1 addition & 1 deletion maps/SoulHouseB3F.asm
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ SoulHouseB3F_MapScriptHeader:
def_bg_events

def_object_events
object_event 4, 13, SPRITE_GRAMPS, SPRITEMOVEDATA_STANDING_UP, 0, 0, -1, -1, PAL_NPC_BLUE, OBJECTTYPE_SCRIPT, 0, SoulHouseB3FMrFujiScript, EVENT_GOT_SILPHSCOPE2_FROM_MR_FUJI
object_event 4, 13, SPRITE_ELDER, SPRITEMOVEDATA_STANDING_UP, 0, 0, -1, -1, PAL_NPC_BLUE, OBJECTTYPE_SCRIPT, 0, SoulHouseB3FMrFujiScript, EVENT_GOT_SILPHSCOPE2_FROM_MR_FUJI
itemball_event 6, 9, ESCAPE_ROPE, 1, EVENT_SOUL_HOUSE_B3F_ESCAPE_ROPE

object_const_def
Expand Down