Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bad conditional in Combat.js -> findCombatant() that was breaking PvP #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jamesheston
Copy link

Added target.isNpc check before !target.hasBehavior("combat") check inside Combat.js:findCombatant() to make PvP work again. Before, when trying to attack another player, even when both had meta.pvp
=== true set, you would only get the message "They aren't here," and combat wouldn't initiate.

…nside Combat.js:findCombatant() to make PvP work again. Before, when trying to attack another player, even when both had meta.pvp = true set, you would only get the message "They aren't here," and combat wouldn't initiate.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant