Add custom taxonomy support #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 similar comments
|
Hi, when it will be merged to the core ? thank you |
|
I'm also interested to know if it will be merged at some point. |
|
I am also interested to know when it will be merged. |
|
Is there a timeline for when this will be merged? I would like to use Lumberjack professionally but this is quite a large missing feature which makes me reluctant to implement it in my workplace just yet. |
|
+1 on this merge request, any idea when this could be implemented? |
|
🆙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
As discussed here this adds support for custom taxonomy. I took the same structure and way of doing things as the custom "Post" types so it should be consistent with this.
Does this close any currently open issues?
Yes, it should fixes Rareloop/lumberjack#16
Any relevant logs, error output, etc?
No :) and all added test are ✔
Any other comments?
We will add Lumberjack to our base theme and taxonomies is a must. Let me know if I need to make some changes, I would be more than happy to help with this feature : )
And once it's merged I will make the required changes to document it here with a pull request https://github.com/Rareloop/lumberjack-docs