Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accounting fix integration test #3

Closed
wants to merge 10 commits into from

Conversation

zerosnacks
Copy link
Contributor

@zerosnacks zerosnacks commented May 11, 2022

Implements the accounting fix integration test

@zerosnacks zerosnacks changed the title WIP: add accounting fix integration test Add accounting fix integration test May 12, 2022
@zerosnacks
Copy link
Contributor Author

Please note the conflicting file - development is now branching off of fuse-reactive-audit instead of fuse-fixed-accounting meaning the fix does not exist yet inside of this repo.

@zerosnacks
Copy link
Contributor Author

zerosnacks commented May 16, 2022

Not exactly sure what has changed in the meantime as last week the test ran perfectly fine with the same settings (block number: 14684685).

Currently throws on line 71 of CEtherDelegateTempExploitAccounting.sol

[FAIL. Reason: Expect account #1 borrow balance to start at 0.] testShouldMergeAttackersSupplyAndBorrowBalances() (gas: 11018600)

@zerosnacks
Copy link
Contributor Author

@sriyantra do we still need this PR?

@sriyantra
Copy link
Collaborator

@sriyantra do we still need this PR?

nope, closing

@sriyantra sriyantra closed this May 23, 2022
@zerosnacks zerosnacks deleted the feature/accounting-fix-integration-test branch May 23, 2022 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants