Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speed up domain loading #12987

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

raoulvm
Copy link
Contributor

@raoulvm raoulvm commented Jan 8, 2024

Domain loading is extremely slow for large bots - about 5 Mins for a 3.3 MBytes domain (including responses), and that is due to multiple times loading and parsing the same file. This commit addresses that, be removing the validation if loading from a model tar.gz and loading the file(s) only once if reading from a directory.

Proposed changes:

  • do not read the domain files multiple times, do the validation only once (when training), or skip it (when loading model)

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Domain loading is extremely slow for large bots - about 5 Mins for a 3.3 MBytes domain (including responses), and that is due to multiple times loading and parsing the same file.
This commit addresses that, be removing the validation if loading from a model tar.gz and loading the file(s) only once if reading from a directory.
@raoulvm raoulvm requested a review from a team as a code owner January 8, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant