Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roll up install prompts with _prompt_install_features() #1556

Merged
merged 3 commits into from
Mar 26, 2024
Merged

Conversation

billz
Copy link
Member

@billz billz commented Mar 24, 2024

No description provided.

@billz billz merged commit 48e7b7a into master Mar 26, 2024
3 checks passed
@billz billz deleted the maint/installer branch March 27, 2024 17:14
@bogen85
Copy link

bogen85 commented Mar 30, 2024

The check for an incompatible distro fails to detect Debian Bookworm as valid.

                             dP      version 3.1.1

The Quick Installer will guide you through a few easy steps

RaspAP Install: Configure update
OS compatibility check
[ \u2718 error ]  Unsupported Desktop distro detected. Please see the docs. 

my /etc/os-release

PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

I've updated online multiple times via /about -> "Check for update".

Debian Bookworm is listed as compatible...
https://docs.raspap.com/#compatible-operating-systems

@billz
Copy link
Member Author

billz commented Mar 30, 2024

Exec dpkg-query -W -f='${Status}' raspberrypi-ui-mods and post the result.

@bogen85
Copy link

bogen85 commented Mar 31, 2024

$ dpkg-query -W -f='${Status}' raspberrypi-ui-mods
dpkg-query: no packages found matching raspberrypi-ui-mods

This is not on a Raspberry Pi. This is an x86_64 VM. I've been running RaspAP in this VM since Jan 25 of this year when 3.0.5 came out, and have updated to each new release via the WebUI.

@billz
Copy link
Member Author

billz commented Mar 31, 2024

Good to know, thanks. The dpkg output in your x86_64 VM differs from what I found in our supported Debian distros ("not-installed"). The quick solution would be to add this to the condition, unless a more robust method exists for detecting a desktop environment.

Unfortunately, many users ignore the docs and install RaspAP on RPi OS Desktop, then report in various forums that it doesn't work. The check is intended to mitigate this and steer users toward compatible distros.

@bogen85
Copy link

bogen85 commented Mar 31, 2024

Thanks! I applied the v3.1.2 update and it worked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants