Use jdk22 GA instead of EA #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code was never used because StringLiteralConcatenation and ExtendedStringLiteral extend StringLiterals and get handled a few lines above. We might need to add it back and fix it if we want to copy annotations like @annotation("a" + "b") without transforming them to @annotation("ab")
Fix Eclipse-I tests
…s correct, it is the tests that are wrong: Useful for small refactors that cause big test file changes.
…e lost. 15 years and nobody found this bug - not worth an issue or a changelog.
…-cases now have `@Generated` annotations where before they did not.
…efaulted: eclipse usually skipped tests.
…-processor-rounds'
…ever so slightly; timestamps of zip entries is now preserved.
…1/lombok into eclipse-synchronized-error
Update annotation value index
- closeQuietly is a pet peeve of mine; it is an abomination that must never be. - All actual resources are closed; all filters aren't because there is no need. - the underlying problem (of 'flushing' zips) is addressed.
This reverts commit 04c9755. The nature of the fix is to simply scan the TypeMirror for 'lombok shenanigans'; if it finds them, the type is not complete; if there are none, the type is. This fundamentally does not work - lombok shenanigans may remain even if lombok is done (`@lombok.NonNull` for example), and lombok shenanigans don't just appear as annotations on the type; they can appear in many forms: Annotations on local var decls, or even method calls to `Lombok.safeDeNull` or whatnot. safeDenull is made up, but we might add it someday. `@Getter` on a field isn't though, and suffers from the same problem.
Fix typo in With.html
[ci] Switch to Ubuntu 24.04 (ships with ant 1.10.14)
fix: Don't alter the AST node positions of original code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've already done the docker provisioning update, that should fix the broken check