Fixing Zip Slip vulnerability #111
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviadatsnyk
reviewed
Jun 18, 2018
src/me/raynes/fs/compression.clj
Outdated
| (java.io ByteArrayOutputStream File))) | ||
|
|
||
| (defn- check-final-path-inside-target-dir! [f target-dir entry] | ||
| (when-not (-> f .getCanonicalPath (.startsWith (.getCanonicalPath target-dir))) |
There was a problem hiding this comment.
@dlebrero great job fixing this!
can you please add the path separator after (.getCanonicalPath target-dir) and make it
(str (.getCanonicalPath target-dir) (java.io.File/separator)) (or any better implementation)?
This is to make sure that an evil file like /tmp/safe.UNSAFE/evil.sh cannot be written if the target directory is /tmp/safe.
See also the java reference implementation https://snyk.io/research/zip-slip-vulnerability#java.
|
@aviadatsnyk thanks a lot for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/snyk/zip-slip-vulnerability