ADD HTML ,CSS #20
Open
ADD HTML ,CSS #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MustafaMerie
reviewed
May 4, 2020
| } | ||
| .container{ | ||
| display:flex; | ||
| flex-flow:flex-direction; |
There was a problem hiding this comment.
The flex-flow CSS property is a shorthand property for flex-direction and flex-wrap.
So use with it the flex-direction values and not the property itself.
| height: 40px; | ||
| margin-left: 10px; | ||
| } | ||
| .container >ul>li>a{ |
There was a problem hiding this comment.
you can simply target the a tag here without the use of >
| .ul-child li{ | ||
| text-decoration:none; | ||
| margin:10px; | ||
| list-style-type: none; |
There was a problem hiding this comment.
it's better to use the list-style on the ul tag itself.
| background-color: darkcyan; | ||
| } | ||
| /*end skills*/ | ||
| /*start experience*/ |
There was a problem hiding this comment.
liked you are using the HTML comments here, always consider using it.
| } | ||
| .divparent{ | ||
| display: flex; | ||
| background-color: darkcyan; |
There was a problem hiding this comment.
is this the right color as the screenshot?
| .form textarea{ | ||
| margin: 20px; | ||
| height: 70px; | ||
| width: 400px; |
There was a problem hiding this comment.
consider using cols=" " rows=" " to set the height and width for textarea tag
MustafaMerie
added
Reviewed By Mohammed
reviewed
and removed
reviewed
Reviewed By Mohammed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i compelet it without grid