Skip to content

Conversation

JalalArif
Copy link

first commit

@osamaakb
Copy link

osamaakb commented May 3, 2020

Good Job Jalal, I liked that you tried to finish it and make it even responsive, couple of notes I have for you, first of all, I can't actually comment on your code since you pushed a zip file to GitHub and that's not a good practice, you should push your project files without compression.
I saw your CSS and there is some stuff that would be really nice to see (ex. padding around the nav ul), the last thing is I saw you are using (px) for the skills li item which its better if you used (%) instead (ex. 33% for larger screens, 50% for medium size screen or tablets and 100% for smartphones screens), lastly I see lots spaces between your CSS lines and these makes your code hard to read, try to minimize them for later 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants