-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review version(1.0) #7
Open
AhmadDuhoki
wants to merge
38
commits into
ReCoded-Org:master
Choose a base branch
from
AhmadDuhoki:review
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27,696
−0
Open
Changes from 7 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
d350e7f
Project Str
mahmodlte 6eb12c6
added react bootstrap
mahmodlte bdcfbec
comp
mahmodlte bff1bf7
adding main
shadan72 49f77fe
fixing main part
shadan72 664fe86
first version of navbar component
mahmodlte 1061907
Merge branch 'master' of https://github.com/AhmadDuhoki/iraq-bc-movie…
mahmodlte 13b6978
first version of navbar
mahmodlte 29d3970
removed react stater files
mahmodlte 5d883c4
jason
AhmadDuhoki ea1df7d
Merge branch 'master' of https://github.com/AhmadDuhoki/iraq-bc-movie…
AhmadDuhoki 6a08d86
changed to useState hook
mahmodlte 158339f
did small changes
mahmodlte 63f6b40
updated the onChange event
mahmodlte 53b0608
Merge branch 'master' of https://github.com/AhmadDuhoki/iraq-bc-movie…
AhmadDuhoki cc01297
in class work
mahmodlte 067d28a
added spinner
mahmodlte da3aadc
Merge branch 'master' into development
mahmodlte 43c6bd6
Spinner done
mahmodlte 3d1aade
optmized code
mahmodlte 288891e
learning to pass fetch data to other comps
mahmodlte c8e0581
some changes
AhmadDuhoki ac1c3ab
0bec107
add app.js
Zainab6 cdba504
Merge branch 'master' of https://github.com/AhmadDuhoki/iraq-bc-movie…
AhmadDuhoki 336be77
Merge branch 'master' of https://github.com/AhmadDuhoki/iraq-bc-movie…
mahmodlte 170d1e1
fetch fixed
mahmodlte ee612f0
handleQuery done
mahmodlte 581ea7b
Merge branch 'master' of https://github.com/AhmadDuhoki/iraq-bc-movie…
mahmodlte f0881b0
add app.js
AhmadDuhoki 1be5412
fixed merge conflicts
AhmadDuhoki 7eb3e9e
fixing app component
shadan72 ddcf430
made some changes
mahmodlte 6e83cf7
Merge branch 'master' of https://github.com/AhmadDuhoki/iraq-bc-movie…
mahmodlte ddf5892
MoviesGrid and MovieItem is done
mahmodlte 77a04b8
code improvement
mahmodlte e3de473
fixed the image show of the grids
AhmadDuhoki 51d1ffa
fixed
AhmadDuhoki File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
import React from 'react'; | ||
|
||
export default function Main(){ | ||
return <div>This is main</div> | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,55 @@ | ||
import React from "react"; | ||
import { Navbar } from "react-bootstrap"; | ||
import { Navbar, Nav } from "react-bootstrap"; | ||
import React, { Component } from "react"; | ||
class navBar extends Component { | ||
constructor(props) { | ||
super(props); | ||
this.state = { | ||
movieSearch: "", | ||
}; | ||
} | ||
handleMovieSearch = (event) => { | ||
this.setState({ | ||
movieSearch: event.target.value, | ||
}); | ||
}; | ||
handleSubmit = (event) => { | ||
event.preventDefault(); | ||
moviesData(this.state.movieSearch); | ||
}; | ||
render() { | ||
return ( | ||
<> | ||
<Navbar bg="dark"> | ||
<Navbar.Brand href="#">Assassins Movies</Navbar.Brand> | ||
|
||
export default function navBar() { | ||
return ( | ||
<> | ||
<Navbar bg="dark" expand="lg"> | ||
<Navbar.Brand href="#">Movies</Navbar.Brand> | ||
</Navbar> | ||
</> | ||
); | ||
<Nav> | ||
<Nav.Link href="#home">Home</Nav.Link> | ||
</Nav> | ||
<form className="form-inline my-2" onSubmit={this.handleSubmit}> | ||
<input | ||
className="form-control" | ||
type="search" | ||
placeholder="Search for a Movie" | ||
value={this.state.movieSearch} | ||
onChange={this.handleMovieSearch} | ||
></input> | ||
<button type="submit">Search</button> | ||
</form> | ||
</Navbar> | ||
</> | ||
); | ||
} | ||
} | ||
//function SearchBox() { | ||
// return <></>; | ||
//} | ||
export default navBar; | ||
|
||
function moviesData(Searchquery) { | ||
fetch( | ||
`https://api.themoviedb.org/3/search/movie/?api_key=1d54e327869a62aba4dc1b58c2b30233&query=${Searchquery}` | ||
) | ||
.then((movies) => movies.json()) | ||
.then((movieData) => console.log(movieData.results)); | ||
} | ||
moviesData(); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the fetch working? because in the demo it's not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Mustafa for the comments, i fixed all except the demo one cause it is working in the vscode but there are some issues in the github page.