Address review comments

ReFil · Jun 18, 2024 · 2852fe3 · 2852fe3
1 parent f7dee82
commit 2852fe3
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/app/Kconfig b/app/Kconfig
@@ -147,7 +147,7 @@ menuconfig ZMK_BLE
     select BT_SMP_APP_PAIRING_ACCEPT
     select BT_PERIPHERAL
     select BT_DIS
-    select BT_DEVICE_NAME_DYNAMIC
+    imply BT_DEVICE_NAME_DYNAMIC
     imply BT_SETTINGS if !ARCH_POSIX
     imply SETTINGS if !ARCH_POSIX
     imply ZMK_BATTERY_REPORTING if !ARCH_POSIX

diff --git a/app/include/zmk/ble.h b/app/include/zmk/ble.h
@@ -36,7 +36,7 @@ char *zmk_ble_active_profile_name(void);
 
 int zmk_ble_unpair_all(void);
 
-void zmk_ble_set_device_name(char *name);
+int zmk_ble_set_device_name(char *name);
 
 #if IS_ENABLED(CONFIG_ZMK_SPLIT_ROLE_CENTRAL)
 int zmk_ble_put_peripheral_addr(const bt_addr_le_t *addr);

diff --git a/app/src/ble.c b/app/src/ble.c
@@ -319,19 +319,24 @@ bt_addr_le_t *zmk_ble_active_profile_addr(void) { return &profiles[active_profil
 
 char *zmk_ble_active_profile_name(void) { return profiles[active_profile].name; }
 
-void zmk_ble_set_device_name(char *name) {
+int zmk_ble_set_device_name(char *name) {
     // Copy new name to advertising parameters
-    bt_set_name(name);
+    int err = bt_set_name(name);
     LOG_DBG("New device name: %s", name);
+    if (err) {
+        LOG_ERR("Failed to set new device name (err %d)", err);
+        return err;
+    }
     if (advertising_status == ZMK_ADV_CONN) {
         // Stop current advertising so it can restart with new name
-        int err = bt_le_adv_stop();
+        err = bt_le_adv_stop();
         advertising_status = ZMK_ADV_NONE;
         if (err) {
             LOG_ERR("Failed to stop advertising (err %d)", err);
+            return err;
         }
     }
-    update_advertising();
+    return update_advertising();
 }
 
 #if IS_ENABLED(CONFIG_ZMK_SPLIT_ROLE_CENTRAL)