Fix decoding Alpha Initialization #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried using this library and it wasn't working for me. I tracked the issue down to the alpha initialization in the decoder.
When encoding we initialize prevA to 255. So if the first pixel has an alpha of 255, then we will add a QOI_OP_RGB op as the first op.
When decoding this, we will get a QOI_OP_RGB for the first pixel and leave A at it's current value of -1. So a will be -1 when it should be 255 in this case.
I am not sure if there is some context of how this was being used that makes this work that I am possibly missing.