Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Set patch options via CLI #336

Merged
merged 4 commits into from
Aug 12, 2024
Merged

feat!: Set patch options via CLI #336

merged 4 commits into from
Aug 12, 2024

Conversation

oSumAtrIX
Copy link
Member

@oSumAtrIX oSumAtrIX commented Aug 3, 2024

Depends on #335.
Once #335 is merged, this PR should be rebased on dev.

This is a breaking change and gets rid of the old approach of storing an options.json file

@oSumAtrIX oSumAtrIX changed the title build: Refactor to DSL to bump ReVanced Patcher feat: Set patch options via CLI Aug 3, 2024
@oSumAtrIX oSumAtrIX changed the title feat: Set patch options via CLI feat!: Set patch options via CLI Aug 3, 2024
@oSumAtrIX oSumAtrIX force-pushed the feat/cli-options branch 3 times, most recently from 28099f7 to 3cd6dbe Compare August 9, 2024 01:20
@oSumAtrIX oSumAtrIX marked this pull request as ready for review August 12, 2024 20:10
@oSumAtrIX oSumAtrIX merged commit 2300243 into dev Aug 12, 2024
3 checks passed
@oSumAtrIX oSumAtrIX deleted the feat/cli-options branch August 12, 2024 20:12
revanced-bot pushed a commit that referenced this pull request Aug 12, 2024
# [5.0.0-dev.1](v4.6.0...v5.0.0-dev.1) (2024-08-12)

### Features

* Set patch options via CLI ([#336](#336)) ([2300243](2300243))

### BREAKING CHANGES

* This commit changes various CLI options and removes the `options.json` file. Instead, patch options can now be passed via CLI options
github-actions bot pushed a commit that referenced this pull request Nov 10, 2024
# [5.0.0](v4.6.0...v5.0.0) (2024-11-10)

### Bug Fixes

* Check for null when no device serial was specified ([1da8ae9](1da8ae9))
* List if patch option is required ([#346](#346)) ([98ff0c3](98ff0c3))
* Make CLI ArgGroup non-exclusive to be able to disable and enable patches at the same time ([1bb0d13](1bb0d13))
* Make patches selectable by using a mutable collection for the selection option ([751fa1d](751fa1d))
* Make the patch command work without specifying any selection ([ba159a3](ba159a3))
* Print in new line correctly ([c2dc9d7](c2dc9d7))
* Use the first connected device when no ADB device is specified ([5f952f3](5f952f3))

### Features

* Set patch options via CLI ([#336](#336)) ([2300243](2300243))
* Show error about no installation device found at the beginning ([3300e6b](3300e6b))
* Simplify command and option names and descriptions ([#338](#338)) ([6e7797a](6e7797a))
* Simplify option descriptions ([45c998b](45c998b))

### BREAKING CHANGES

* Options have been renamed.
* This commit changes various CLI options and removes the `options.json` file. Instead, patch options can now be passed via CLI options
github-actions bot pushed a commit to E85Addict/revanced-cli that referenced this pull request Nov 10, 2024
# [5.0.0](v4.6.0...v5.0.0) (2024-11-10)

### Bug Fixes

* Check for null when no device serial was specified ([1da8ae9](1da8ae9))
* List if patch option is required ([ReVanced#346](https://github.com/E85Addict/revanced-cli/issues/346)) ([98ff0c3](98ff0c3))
* Make CLI ArgGroup non-exclusive to be able to disable and enable patches at the same time ([1bb0d13](1bb0d13))
* Make patches selectable by using a mutable collection for the selection option ([751fa1d](751fa1d))
* Make the patch command work without specifying any selection ([ba159a3](ba159a3))
* Print in new line correctly ([c2dc9d7](c2dc9d7))
* Use the first connected device when no ADB device is specified ([5f952f3](5f952f3))

### Features

* Set patch options via CLI ([ReVanced#336](https://github.com/E85Addict/revanced-cli/issues/336)) ([2300243](2300243))
* Show error about no installation device found at the beginning ([3300e6b](3300e6b))
* Simplify command and option names and descriptions ([ReVanced#338](https://github.com/E85Addict/revanced-cli/issues/338)) ([6e7797a](6e7797a))
* Simplify option descriptions ([45c998b](45c998b))

### Performance Improvements

* --rip-lib and --unsigned ([3984c8a](3984c8a))
* Personal Sync Upstream ([fc754ee](fc754ee))

### BREAKING CHANGES

* Options have been renamed.
* This commit changes various CLI options and removes the `options.json` file. Instead, patch options can now be passed via CLI options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant