This repository has been archived by the owner on Oct 26, 2024. It is now read-only.
fix(YouTube - Settings): Use multiline preference title for localized languages #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LisoUseInAIKyrios
force-pushed
the
fix/settings_preferences_multiline
branch
from
b29a99a to
8499d9e
Compare
|
This is a very important PR for us, because very often we have to cut the title translation to fit in screen.
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
oSumAtrIX
reviewed
Oct 24, 2024
|
With PR ReVanced/revanced-patches#3462, ReVanced Integrations has been merged into ReVanced Patches. This PR must be reopened in the ReVanced Patches repository and adjusted to the new build system. ReVanced Integration is now understood as "extensions" according to the ReVanced Patcher API. As extensions are now on a per-patch basis, this PR may be subject to a separate extension. If not, the PR can change the shared extension in ReVanced Patches. Thanks, for the PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes preference titles clipping when using localized langauges.
Many of the localized preference titles do not fit into 1 line and many are unreadable.
This PR sets the titles to multiline if the device is using a localized language.
The English strings do not require multiline, and the 2 or 3 English preferences that overrun are only partially clipped and still readable. Making those couple of preferences multiline looks weird and out of place, and visually it is better to clip the text and keep all titles 1 line.
Before (Single line)
After (Multiline)