Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator #4180

Merged

Conversation

LisoUseInAIKyrios
Copy link
Contributor

iOS is is starting to have playback issues and patch changes are needed.

For now, use Android VR as default since it still works.

Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iOS can technically be removed otherwise it may return video streams that fail to play

@LisoUseInAIKyrios
Copy link
Contributor Author

Ok then for this PR I'll remove the spoof client type setting from the UI so users cannot change from Android VR.

@LisoUseInAIKyrios
Copy link
Contributor Author

Or add Android TV as a secondary client type. I'll try that now.

@oSumAtrIX
Copy link
Member

Not only that, if VR requests fail such as for kids videos, then iOS would be used. It needs to be removed

@LisoUseInAIKyrios
Copy link
Contributor Author

Yes that's true. Will remove iOS.

@oSumAtrIX
Copy link
Member

oSumAtrIX commented Dec 21, 2024

ANDROID_CREATOR is being suggested. You can find it in the yt-dlp repo

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Spoof video streams): Use Android VR as default spoof client fix(YouTube - Spoof video streams): Remove iOS client, add Android TV client Dec 21, 2024
@LisoUseInAIKyrios
Copy link
Contributor Author

Maybe in a separate PR bump the recommended version to 19.47.53, since so many people think the app version is the same as the patch version.

@LisoUseInAIKyrios LisoUseInAIKyrios changed the title fix(YouTube - Spoof video streams): Remove iOS client, add Android TV client fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator Dec 21, 2024
@LisoUseInAIKyrios
Copy link
Contributor Author

Seems ready. Any opinions before committing?

@LisoUseInAIKyrios LisoUseInAIKyrios merged commit 86abfb2 into ReVanced:dev Dec 21, 2024
1 check passed
@LisoUseInAIKyrios LisoUseInAIKyrios deleted the fix/spoof_android_vr_default branch December 21, 2024 11:33
github-actions bot pushed a commit that referenced this pull request Dec 21, 2024
## [5.6.1-dev.2](v5.6.1-dev.1...v5.6.1-dev.2) (2024-12-21)

### Bug Fixes

* **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2))
@Karthik-Subbu
Copy link

iOS is is starting to have playback issues and patch changes are needed.

For now, use Android VR as default since it still works.

Many users started reporting? IOS failing only for age restricted music videos or in general?

@LisoUseInAIKyrios
Copy link
Contributor Author

That's what I said

iOS is is starting to have playback issues and patch changes are needed.

@Karthik-Subbu
Copy link

I think it is worth evaluating how the spoof client approach behaves for playback issues. Would there be any difference if ios client is used but with the old spoof client approach?

@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Dec 21, 2024 that may be closed by this pull request
3 tasks
github-actions bot pushed a commit that referenced this pull request Dec 22, 2024
# [5.7.0](v5.6.0...v5.7.0) (2024-12-22)

### Bug Fixes

* **YouTube - Force original audio:** Use correct availability for settings UI ([a7eedcb](a7eedcb))
* **YouTube - Spoof video stream:** Remove UI client type setting.  Allow setting default audio language. ([#4184](#4184)) ([99f3f29](99f3f29))
* **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2))
* **YouTube:** Change fingerprints to support a wider range of target versions ([8a09174](8a09174))

### Features

* **YouTube:** Support version `19.47.53` ([#4182](#4182)) ([2089e61](2089e61))
@alcatraz-zz
Copy link

alcatraz-zz commented Dec 23, 2024

How about changing the default spoof setting but allow iOS to remain available?

Edit: I noticed the iOS client got updated in 5.6.0. I'm on 5.5.1
and haven't experienced issues. Maybe it's your update people are having issues with?

I reverted to an older patch version to enable iOS spoofing. I use it daily and never had playback issues. I need it because it's the only spoof setting that offers AV1 streams. (AV1 makes a big difference for me because I get higher qualities/less buffer issues compared with VP9. This is isp and not app related.)

@LisoUseInAIKyrios
Copy link
Contributor Author

Going to add iOS tv as an option.

Regular iOS is dead and it's only a matter of time before it stops working for everyone (likely very soon).

@Karthik-Subbu
Copy link

Default audio language can be set any language now? Or any restrictions?

@alcatraz-zz
Copy link

Going to add iOS tv as an option.

Regular iOS is dead and it's only a matter of time before it stops working for everyone (likely very soon).

Is there any other way to enable AV1? Hmm.

@LisoUseInAIKyrios
Copy link
Contributor Author

iOS tv supports AV1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: YouTube Playback stopped at 1:00
4 participants