-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator #4180
fix(YouTube - Spoof video streams): Remove iOS, add clients Android TV and Android Creator #4180
Conversation
patches/src/main/kotlin/app/revanced/patches/youtube/misc/spoof/SpoofVideoStreamsPatch.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS can technically be removed otherwise it may return video streams that fail to play
Ok then for this PR I'll remove the spoof client type setting from the UI so users cannot change from Android VR. |
Or add Android TV as a secondary client type. I'll try that now. |
Not only that, if VR requests fail such as for kids videos, then iOS would be used. It needs to be removed |
Yes that's true. Will remove iOS. |
ANDROID_CREATOR is being suggested. You can find it in the yt-dlp repo |
Maybe in a separate PR bump the recommended version to |
Seems ready. Any opinions before committing? |
## [5.6.1-dev.2](v5.6.1-dev.1...v5.6.1-dev.2) (2024-12-21) ### Bug Fixes * **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2))
Many users started reporting? IOS failing only for age restricted music videos or in general? |
That's what I said
|
I think it is worth evaluating how the spoof client approach behaves for playback issues. Would there be any difference if ios client is used but with the old spoof client approach? |
# [5.7.0](v5.6.0...v5.7.0) (2024-12-22) ### Bug Fixes * **YouTube - Force original audio:** Use correct availability for settings UI ([a7eedcb](a7eedcb)) * **YouTube - Spoof video stream:** Remove UI client type setting. Allow setting default audio language. ([#4184](#4184)) ([99f3f29](99f3f29)) * **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2)) * **YouTube:** Change fingerprints to support a wider range of target versions ([8a09174](8a09174)) ### Features * **YouTube:** Support version `19.47.53` ([#4182](#4182)) ([2089e61](2089e61))
How about changing the default spoof setting but allow iOS to remain available? Edit: I noticed the iOS client got updated in 5.6.0. I'm on 5.5.1 I reverted to an older patch version to enable iOS spoofing. I use it daily and never had playback issues. I need it because it's the only spoof setting that offers AV1 streams. (AV1 makes a big difference for me because I get higher qualities/less buffer issues compared with VP9. This is isp and not app related.) |
Going to add iOS tv as an option. Regular iOS is dead and it's only a matter of time before it stops working for everyone (likely very soon). |
Default audio language can be set any language now? Or any restrictions? |
Is there any other way to enable AV1? Hmm. |
iOS tv supports AV1. |
iOS is is starting to have playback issues and patch changes are needed.
For now, use Android VR as default since it still works.