-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Merge branch dev
to main
#4183
Conversation
## [5.6.1-dev.1](v5.6.0...v5.6.1-dev.1) (2024-12-21) ### Bug Fixes * **YouTube:** Change fingerprints to support a wider range of target versions ([8a09174](8a09174))
…V and Android Creator (#4180)
## [5.6.1-dev.2](v5.6.1-dev.1...v5.6.1-dev.2) (2024-12-21) ### Bug Fixes * **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2))
## [5.6.1-dev.3](v5.6.1-dev.2...v5.6.1-dev.3) (2024-12-21) ### Bug Fixes * **YouTube - Force original audio:** Use correct availability for settings UI ([a7eedcb](a7eedcb))
# [5.7.0-dev.1](v5.6.1-dev.4...v5.7.0-dev.1) (2024-12-21) ### Features * **YouTube:** Support version `19.47.53` ([#4182](#4182)) ([2089e61](2089e61))
@LisoUseInAIKyrios I think 19.50 will be the last version for this year, maybe it's better to add a support for this instead? |
19.50 has bugs in the miniplayer. 19.47 is better. |
Need to merge strings, otherwise patching will show warnings. |
Is there a way to reduce the fragility if the translations system? Errors like this shouldn't be easy to make |
Yes, AddResourcePatch can check and do not add translations from a non english (non That would fix these harmless warnings, where a string was deleted but since Crowdin has not been synced the localized languages still have the string: |
The AddResourcesPatch should not fulfill specific requirements that don't apply to the Android specifications because it works as a generic patch that adds resource files. So unless it is invalid behavior to add localized strings unless the original exists, probably adding the behavior to not add the localized string may go against the specs |
Adding localized strings without a default does go against android standards. The warning shown above is from resource compilation where it fixes the problem by not including the localized string. Add resources could avoid the warning by doing the check itself and not adding. Or alternatively always merge crowdin strings before merging to main. Dev releases will still show the warning but it's dev so who cares. |
In that case I agree AddResourcesPatch should explicitly handle this invalid behavior |
This pull request will Merge branch
dev
tomain
.Before merging this PR