Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Merge branch dev to main #4183

Merged
merged 11 commits into from
Dec 22, 2024
Merged

chore: Merge branch dev to main #4183

merged 11 commits into from
Dec 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

This pull request will Merge branch dev to main.

Before merging this PR

  • Pull translations from Crowdin

LisoUseInAIKyrios and others added 7 commits December 21, 2024 12:55
## [5.6.1-dev.1](v5.6.0...v5.6.1-dev.1) (2024-12-21)

### Bug Fixes

* **YouTube:** Change fingerprints to support a wider range of target versions ([8a09174](8a09174))
## [5.6.1-dev.2](v5.6.1-dev.1...v5.6.1-dev.2) (2024-12-21)

### Bug Fixes

* **YouTube - Spoof video streams:** Remove iOS, add clients Android TV and Android Creator ([#4180](#4180)) ([86abfb2](86abfb2))
## [5.6.1-dev.3](v5.6.1-dev.2...v5.6.1-dev.3) (2024-12-21)

### Bug Fixes

* **YouTube - Force original audio:** Use correct availability for settings UI ([a7eedcb](a7eedcb))
@LisoUseInAIKyrios LisoUseInAIKyrios linked an issue Dec 21, 2024 that may be closed by this pull request
3 tasks
LisoUseInAIKyrios and others added 3 commits December 21, 2024 18:49
## [5.6.1-dev.4](v5.6.1-dev.3...v5.6.1-dev.4) (2024-12-21)

### Bug Fixes

* **YouTube - Spoof video stream:** Remove UI client type setting.  Allow setting default audio language. ([#4184](#4184)) ([99f3f29](99f3f29))
@LisoUseInAIKyrios LisoUseInAIKyrios marked this pull request as ready for review December 21, 2024 15:07
# [5.7.0-dev.1](v5.6.1-dev.4...v5.7.0-dev.1) (2024-12-21)

### Features

* **YouTube:** Support version `19.47.53` ([#4182](#4182)) ([2089e61](2089e61))
@0xrxL
Copy link

0xrxL commented Dec 21, 2024

@LisoUseInAIKyrios I think 19.50 will be the last version for this year, maybe it's better to add a support for this instead?

@LisoUseInAIKyrios
Copy link
Contributor

19.50 has bugs in the miniplayer. 19.47 is better.

@oSumAtrIX oSumAtrIX merged commit 6e7bd4b into main Dec 22, 2024
1 check passed
@LisoUseInAIKyrios
Copy link
Contributor

Need to merge strings, otherwise patching will show warnings.

@oSumAtrIX
Copy link
Member

Is there a way to reduce the fragility if the translations system? Errors like this shouldn't be easy to make

@LisoUseInAIKyrios
Copy link
Contributor

LisoUseInAIKyrios commented Dec 22, 2024

Yes, AddResourcePatch can check and do not add translations from a non english (non /values/strings.xml file), unless there also is an English string that has the same key.

That would fix these harmless warnings, where a string was deleted but since Crowdin has not been synced the localized languages still have the string:
WARNING: warn: removing resource app.revanced.android.youtube:string/revanced_spoof_video_streams_about_android_vr_summary without required default value.

@oSumAtrIX
Copy link
Member

The AddResourcesPatch should not fulfill specific requirements that don't apply to the Android specifications because it works as a generic patch that adds resource files. So unless it is invalid behavior to add localized strings unless the original exists, probably adding the behavior to not add the localized string may go against the specs

@LisoUseInAIKyrios
Copy link
Contributor

Adding localized strings without a default does go against android standards.

The warning shown above is from resource compilation where it fixes the problem by not including the localized string. Add resources could avoid the warning by doing the check itself and not adding.

Or alternatively always merge crowdin strings before merging to main. Dev releases will still show the warning but it's dev so who cares.

@oSumAtrIX
Copy link
Member

In that case I agree AddResourcesPatch should explicitly handle this invalid behavior

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: YouTube Playback stopped at 1:00
4 participants