Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hypersphere norm variation #361

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

gkielian
Copy link
Collaborator

This is a slight variation which removes gain and thus performs mapping of the token vector to the surface of a hypersphere.

As to the radius of the hypersphere, optional parameters are added for setting the hypersphere radius directly (defaulting to square root of the embedding dim), also optionally letting it be a learned after initializing.

This is a slight variation which removes gain and thus
performs mapping of the token vector to the surface of a hypersphere.

As to the radius of the hypersphere, optional parameters are added for
setting the hypersphere radius directly (defaulting to square root of the
embedding dim), also optionally letting it be a learned after initializing.
@gkielian gkielian requested a review from klei22 January 19, 2025 07:47
@gkielian gkielian linked an issue Jan 19, 2025 that may be closed by this pull request
Copy link
Collaborator

@klei22 klei22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@klei22 klei22 merged commit 07abd38 into ReaLLMASIC:master Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add HyperSphere Normalization
2 participants