Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a separate CI action for formatting #307

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

bvdmitri
Copy link
Member

@bvdmitri bvdmitri commented May 2, 2024

This pull request introduces the Format.yml action, which automatically generates PRs for formatting suggestions. It also removes the explicit requirement for the code to be perfectly formatted. I believe that as we expand our pool of collaborators, this approach is preferable to banning PR due to formatting issues.

@bvdmitri bvdmitri requested a review from albertpod May 2, 2024 09:35
@bvdmitri
Copy link
Member Author

bvdmitri commented May 2, 2024

Apparently the version 3 is not available. I opened an issue in the formatting action repository.

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (b89f097) to head (d410d81).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files          19       19           
  Lines        1523     1523           
=======================================
  Hits         1290     1290           
  Misses        233      233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri bvdmitri merged commit 8fe0d2b into main Jan 6, 2025
7 checks passed
@bvdmitri bvdmitri deleted the make-formatting-a-separate-action branch January 6, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant