Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add structural dynamics example #392

Merged
merged 9 commits into from
Jan 6, 2025

Conversation

vflores-io
Copy link
Contributor

This PR adds an example of the Augmented Kalman Filter for joint input-state estimation in structural dynamics using RxInfer.jl. The example includes:

  • A structural toy model setup.
  • Synthetic data generation.
  • Joint input-state estimation using the AKF smoother.
  • The example is based on the blog https://vflores-io.github.io/.

@bvdmitri
Copy link
Member

Thanks @vflores-io for the example! Amazing! The core team is at the holiday mood right now, but we are going to review your work as soon as we can. Happy holidays!

@vflores-io
Copy link
Contributor Author

Thank you @bvdmitri ! Heads-up: I will update in the next commit the shear_model png because in the previous version I forgot to draw the k coefficients.
Happy holidays!

@albertpod albertpod requested review from HoangMHNguyen and removed request for Raphael-Tresor December 23, 2024 14:05
@bvdmitri
Copy link
Member

bvdmitri commented Jan 6, 2025

Hey @vflores-io, do you still plan to update the png? I'm not sure if you still want to work on the PR or it can be reviewed?

@vflores-io
Copy link
Contributor Author

Hey @vflores-io, do you still plan to update the png? I'm not sure if you still want to work on the PR or it can be reviewed?

I will push the updated png right now. The changes are minimal, and that is the only change at the moment. I would appreciate it if you could review the PR, thank you for your time!

@bvdmitri
Copy link
Member

bvdmitri commented Jan 6, 2025

Amazing @vflores-io , I adjusted the introduction a bit to my own taste, but I kept most of your text and also kept the attribution (Also added link to your GitHub profile). I also added the notebook to our automated build process. IMO the example is nice and ready to go. I approve but we first should wait till CI completes to merge it.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (b89f097) to head (d346fdc).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #392   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files          19       19           
  Lines        1523     1523           
=======================================
  Hits         1290     1290           
  Misses        233      233           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri
Copy link
Member

bvdmitri commented Jan 6, 2025

Thanks @vflores-io !

@bvdmitri bvdmitri merged commit 51f20c3 into ReactiveBayes:main Jan 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants