Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev node in a rule #394

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Dev node in a rule #394

merged 2 commits into from
Dec 20, 2024

Conversation

bvdmitri
Copy link
Member

This pull request introduces experimental functionality for custom nodes in RxInfer, allowing access to node objects within message passing rules. This feature is intended for advanced scenarios and comes with performance and global state considerations.

Key changes include:

Experimental Features

  • Added a warning about the experimental nature of the new functionality and its potential changes in future releases.

Node Access in Rules

  • Introduced the ability to pass node references to rules, enabling inspection of the current state of other variables, implementation of complex message passing schemes, and experimentation with custom inference algorithms.
  • Provided an example of how to define a custom node and enable node reference passing for it.
  • Demonstrated the use of the getnode() function to access the node object within a rule.

Performance and Global State Considerations

  • Added notes on the performance impact and global state implications of enabling node reference passing, advising caution when using this feature in production code.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.45%. Comparing base (10aa920) to head (713428b).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #394   +/-   ##
=======================================
  Coverage   84.45%   84.45%           
=======================================
  Files          19       19           
  Lines        1525     1525           
=======================================
  Hits         1288     1288           
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bvdmitri bvdmitri merged commit e014d33 into main Dec 20, 2024
7 checks passed
@bvdmitri bvdmitri deleted the dev-node-in-a-rule branch December 20, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants