Use unspecified QoS in QueueScheduler when QoS is unspecified

ReactiveCocoa · Oct 22, 2023 · c71d84f · c71d84f
1 parent 74dce06
commit c71d84f
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 1 deletion.
diff --git a/Sources/Scheduler.swift b/Sources/Scheduler.swift
@@ -363,7 +363,7 @@ public final class QueueScheduler: DateScheduler {
 	///   - targeting: (Optional) The queue on which this scheduler's work is
 	///     targeted
 	public convenience init(
-		qos: DispatchQoS = .default,
+		qos: DispatchQoS = .unspecified,
 		name: String = "org.reactivecocoa.ReactiveSwift.QueueScheduler",
 		targeting targetQueue: DispatchQueue? = nil
 	) {

diff --git a/Tests/ReactiveSwiftTests/SchedulerSpec.swift b/Tests/ReactiveSwiftTests/SchedulerSpec.swift
@@ -261,6 +261,39 @@ class SchedulerSpec: QuickSpec {
 					// enough time to ensure that the first timer was actually cancelled.
 					expect(count).toEventually(equal(timesToRun))
 				}
+
+                it("should propagate QoS values by default") {
+                    expect(scheduler.queue.qos).to(equal(.unspecified))
+
+                    let userInitiatedQueue = DispatchQueue(
+                        label: "reactiveswift.tests.user-initiated",
+                        qos: .userInitiated
+                    )
+                    userInitiatedQueue.suspend()
+
+                    var initialQoS: qos_class_t?
+                    var endQoS: qos_class_t?
+
+                    userInitiatedQueue.async {
+                        initialQoS = qos_class_self()
+
+                        // scheduling should propagate QoS values by default
+                        scheduler.schedule {
+                            endQoS = qos_class_self()
+                        }
+                    }
+
+                    scheduler.queue.resume()
+                    userInitiatedQueue.resume()
+
+                    expect(initialQoS).toEventuallyNot(beNil())
+                    expect(endQoS).toEventuallyNot(beNil())
+
+                    expect(initialQoS).to(equal(QOS_CLASS_USER_INITIATED))
+                    expect(endQoS?.rawValue).to(beGreaterThanOrEqualTo(
+                        initialQoS?.rawValue
+                    ))
+                }
 			}
 		}