Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for xrOS #875

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Add support for xrOS #875

merged 3 commits into from
Mar 18, 2024

Conversation

NachoSoto
Copy link
Member

@NachoSoto NachoSoto commented Jun 24, 2023 •
edited by mluisbrown
Loading

Checklist

  • Updated CHANGELOG.md.

NachoSoto added a commit to ReactiveCocoa/ReactiveCocoa that referenced this pull request Jun 24, 2023
@NachoSoto
Add support for xrOS
f1cbee6 
See also ReactiveCocoa/ReactiveSwift#875
@NachoSoto NachoSoto mentioned this pull request Jun 24, 2023
Merged
NachoSoto added a commit to NachoSoto/AsyncImageView that referenced this pull request Jun 24, 2023
@NachoSoto
Add support for xrOS
c969c04 
See also:
- ReactiveCocoa/ReactiveSwift#875
- ReactiveCocoa/ReactiveCocoa#3740
@NachoSoto NachoSoto mentioned this pull request Jun 24, 2023
Merged
@braker1nine
Copy link
Contributor

braker1nine commented Jun 29, 2023 •
edited
Loading

@NachoSoto would it be preferable to use visionOS in place of xrOS? Since that's how Apple refers to it in Xcode. Seems like this would result in less confusion?

Screenshot 2023-06-29 at 4 53 47 PM

same for ReactiveCocoa/ReactiveCocoa#3740

@NachoSoto
Copy link
Member Author

NachoSoto commented Jun 29, 2023 •
edited
Loading

It might change in a future beta, but as of now xrOS is the name of the platform (similar to iOS/watchOS/tvOS/macOS)

@braker1nine
Copy link
Contributor

Ah I see what you mean. I can't say that doesn't make sense.

I hope that changes. I'm sure we'll all figure it out. But I feel like we're about to see schism in how different libraries refer to it

NachoSoto added a commit to NachoSoto/AsyncImageView that referenced this pull request Feb 3, 2024
@NachoSoto
Add support for xrOS
2bb8031 
See also:
- ReactiveCocoa/ReactiveSwift#875
- ReactiveCocoa/ReactiveCocoa#3740
NachoSoto added a commit to ReactiveCocoa/ReactiveCocoa that referenced this pull request Feb 3, 2024
@NachoSoto
Add support for xrOS
0e05531 
See also ReactiveCocoa/ReactiveSwift#875
NachoSoto added a commit to ReactiveCocoa/ReactiveCocoa that referenced this pull request Feb 3, 2024
@NachoSoto
Add support for xrOS
2efb075 
See also ReactiveCocoa/ReactiveSwift#875
NachoSoto added a commit to NachoSoto/AsyncImageView that referenced this pull request Feb 3, 2024
@NachoSoto
Add support for xrOS
5e2916d 
See also:
- ReactiveCocoa/ReactiveSwift#875
- ReactiveCocoa/ReactiveCocoa#3740
@mluisbrown mluisbrown merged commit 196bf28 into master Mar 18, 2024
5 checks passed
@mluisbrown mluisbrown deleted the xros branch March 18, 2024 16:14
NachoSoto added a commit to ReactiveCocoa/ReactiveCocoa that referenced this pull request May 19, 2024
@NachoSoto
Add support for xrOS
ecec1db 
See also ReactiveCocoa/ReactiveSwift#875
NachoSoto added a commit to ReactiveCocoa/ReactiveCocoa that referenced this pull request May 19, 2024
@NachoSoto
Add support for xrOS
765a475 
See also ReactiveCocoa/ReactiveSwift#875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mluisbrown mluisbrown mluisbrown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NachoSoto @braker1nine @mluisbrown