-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(swedish) reduction achievements #1200
Conversation
This shouldn't happen. the "translation" I commented out are still in English. And in the main reactivedrop_swedish.txt it still have the indention. Something is broken, or I missed something As for the Reduction achievements, it did not send out an error |
Yeah, sometimes it works, sometimes it dosent. Its just weird. |
the issue is probably missing quotation marks in commented out lines |
I checked back and forth, nothing out of ordinary. I saw that when Ben sync the achievement page, the sync also removed the part that commented out the English strings and served it as if it is a "Swedish translation" |
ok. i think the issue is that you cant translate only name and leave description untranslated for an achievement |
Eh, forget about this one. I will probably come back for these later on when going through as much as possible and see if it keeps failing. You can close this pull request. |
I think the issue here is: the achievements should be translated in reactivedrop_swedish.txt |
Could be true. And if what jhh8 said is true, the error was caused for translating the titles but not it descriptions in reactivedrop_swedish. The only way to verify to see if it is true is to translate it, but I can't do it. As for now, I will revert my correction, and then just gonna try and make the Reduction achievement strings go through Edit: Done. Literally just feel like when I summit the major translation PL, so many commits to fix the error. I also don't have the mean to execute the .exe file, I believe I need to down a copy of the repository into my computer and then run it |
If you click the Checks tab at the top of this page, it will show the differences between what you wrote (red) and what the translation sync tool changed it to (green). The sync tool puts both the title and description of an achievement as translated if either one differs from English. |
given permission by Crazymanbos to try and put some of the remaining of what he tried to contribute into the main repository