Skip to content

Commit

Permalink
fix(ci): the bundle is not actually stable, cannot validate with cmp
Browse files Browse the repository at this point in the history
git status --porcelain demands exact equality of the committed bundle
and the one built in CI, but the minification and optimization process
is not completely deterministic, so it's not a reliable test.

We don't actually use the bundle in the published packages, and we in
fact rebuild the bundle automatically as part of the publish.yml
workflow that deploys to gh-pages and production, so this is not useful
test at all!
  • Loading branch information
joanise committed May 2, 2024
1 parent 0ce0404 commit ac94984
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ jobs:
npx nx build web-component
npx nx bundle web-component
npx nx build ngx-web-component
- name: Check that the web-component bundle was up to date
run: |
if git status --porcelain | grep packages/studio-web/src/assets/; then echo ERROR: The web-component bundle is out of date. Please run \"npx nx bundle web-component\" and commit the results, then update the tag and try again.; false; fi
- name: Publish web-component to npmjs
run: |
cd dist/packages/web-component && npm publish --access=public
Expand Down

0 comments on commit ac94984

Please sign in to comment.