Dev.ej/translate route buttons #349
Conversation
|
Review changes with SemanticDiff. Analyzed 8 of 8 files. Overall, the semantic diff is 10% smaller than the GitHub diff.
|
joanise
changed the base branch from
main
to
dev.del/join-studio-and-editor-tours
|
joanise
force-pushed
the
dev.ej/translate-route-buttons
branch
from
84c89bb
to
9c3043a
Compare
joanise
force-pushed
the
dev.ej/translate-route-buttons
branch
from
9c3043a
to
e34ba41
Compare
|
Rebased this PR to the reverted main branch so it can be reviewed properly. It's on top of other PRs, but should still be reviewed by itself. |
|
And it still needs a solution for seeing all three buttons when the text is wider, in French and Spanish, as I initially commented. |
|
Yes, there's a way to do that. at a minimum we could put |
|
Thanks @roedoejet for this suggestion. I've merged it here, with some improvements Del suggested. I think this PR is now ready to review, and hopefully to merge, although I'll clean up the commit history before I do so. |
* style: put each hamburger item on its own line * feat: give the Studio button the home mat-icon Excellent PR review suggestion by Del. * refactor: exclude the icons from the i18n elements in the top menu
joanise
force-pushed
the
dev.ej/translate-route-buttons
branch
from
8c2b40a
to
a674238
Compare
| "maximumWarning": "500kb", | ||
| "maximumError": "2mb" | ||
| "maximumWarning": "1500kb", | ||
| "maximumError": "3mb" |
There was a problem hiding this comment.
We were busting our 2mb budget deploying this, I think it's reasonable to go to 3mb, that's still reasonably small.
| @@ -6,7 +6,7 @@ | |||
| <h1 i18n="Welcome message for app editor" id="welcome-header"> | |||
| Welcome to the ReadAlong Studio Editor | |||
| </h1> | |||
| <p> | |||
| <p i18n="Editor synopsis"> | |||
There was a problem hiding this comment.
Only loosely related to the rest of this PR: I noticed this text was still in English on the fr and es versions.
PR Goal?
Right now, the Studio / Editor / Privacy buttons on the top right of the Studio and Editor are shown in English on the French and Spanish versions. This PR wants to translate them.
Feedback sought?
This should be rubber stamping, but the longer words for Privacy (Privacidad and, much worse, Confidentialité) make the buttons too wide. E.g., on iPhone SE:
fr
es
vs English
At a more reasonable screen size, in English, you fully see the buttons down to 437 pixels wide, and that's perfectly acceptable, but in French you need at least 500 pixels wide to see "Confidentialité" in full. Is there a way to have each of the three buttons auto-shrink when they stop fitting? Ideally, each of the three words would be partially trimmed on the right so that you still see some of each button's text even on a narrow cell phone with 375 pixels wide.
Priority?
medium
How to test?
load the PR preview in each language and play with simulated narrow screens
Confidence?
still low because of the size problems
Version change?
no