Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly solve Python 3.12 compatibility before making the next release #202

Closed
joanise opened this issue Feb 2, 2024 · 4 comments · Fixed by #206
Closed

Properly solve Python 3.12 compatibility before making the next release #202

joanise opened this issue Feb 2, 2024 · 4 comments · Fixed by #206

Comments

@joanise
Copy link
Member

joanise commented Feb 2, 2024

#201 is a work-around that lets us use Python 3.12 for now, but when we publish the next release to PyPI, we have to remove links to github from requirements, instead declaring everything by version.
Hopefully editdistance will have a new release by then, or else we can just remove Python 3.12 support from the next actual release and push it to a subsequent release.

@roedoejet
Copy link
Collaborator

doesn't this fail on Python 3.11 too?

@dhdaines
Copy link
Collaborator

dhdaines commented Feb 2, 2024

There are wheels of editdistance for Python 3.11 for most platforms so it should install fine there: https://pypi.org/project/editdistance/#files

@roedoejet
Copy link
Collaborator

hm ok - I wonder what the issue I was having on 3.11 was. I"ll look into it

@joanise
Copy link
Member Author

joanise commented Feb 2, 2024

3.11 was recently repaired on Windows, and worked fine on Linux.

Oh, I bet you have a fastapi vs pydantic issue. Check out #203 it might fix it.

joanise added a commit that referenced this issue Mar 8, 2024
The authors published 0.8.1 with proper 3.12 packages.

Fixes: #202
joanise added a commit that referenced this issue Mar 12, 2024
The authors published 0.8.1 with proper 3.12 packages.

Fixes: #202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants