Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: editdistance can now come from PyPI again for Py 3.12 #206

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Mar 8, 2024

The authors published 0.8.1 with proper 3.12 packages.

Fixes: #202

The authors published 0.8.1 with proper 3.12 packages.

Fixes: #202
@joanise joanise requested a review from dhdaines March 8, 2024 21:23
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.05%. Comparing base (e36e762) to head (2fdfdef).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #206   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files          21       21           
  Lines        1746     1746           
  Branches      315      315           
=======================================
  Hits         1520     1520           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

CLI load time: 0:00.34
Pull Request HEAD: 2fdfdef0d39635e4c1367be0f0c11e98d7a7bd8d
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:    239309 |     299970 | pkg_resources

@joanise joanise merged commit 8d8dfc2 into main Mar 12, 2024
6 checks passed
@joanise joanise deleted the dev.ej/202-support-python312 branch March 12, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properly solve Python 3.12 compatibility before making the next release
1 participant