Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle unpkg timeouts #156

Merged
merged 3 commits into from
Feb 16, 2023
Merged

handle unpkg timeouts #156

merged 3 commits into from
Feb 16, 2023

Conversation

joanise
Copy link
Member

@joanise joanise commented Feb 16, 2023

Gracefully handle the situation where unpkg is slow and times out

@joanise
Copy link
Member Author

joanise commented Feb 16, 2023

Related to #155 but not a fix, just adding fault tolerance to the system.

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #156 (dbd3942) into master (1ad962b) will increase coverage by 0.30%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #156      +/-   ##
==========================================
+ Coverage   81.66%   81.96%   +0.30%     
==========================================
  Files          26       26              
  Lines        1969     1980      +11     
  Branches      354      354              
==========================================
+ Hits         1608     1623      +15     
+ Misses        320      317       -3     
+ Partials       41       40       -1     
Impacted Files Coverage Δ
readalongs/text/make_package.py 95.71% <100.00%> (+7.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! This is reasonable to do in the CLI

@joanise joanise merged commit 84b6d9e into master Feb 16, 2023
@joanise joanise deleted the dev.request-timeout branch February 16, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants