Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search for noise dictionary to match all SoundSwallower versions (fixes #183) #184

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

dhdaines
Copy link
Collaborator

A healthy dose of silencing for mypy (because SoundSwallower's type annotations may be slightly bogus)

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #184 (662e9a4) into main (567cdf3) will decrease coverage by 0.20%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##             main     #184      +/-   ##
==========================================
- Coverage   87.22%   87.03%   -0.20%     
==========================================
  Files          21       21              
  Lines        1730     1735       +5     
  Branches      315      315              
==========================================
+ Hits         1509     1510       +1     
- Misses        185      188       +3     
- Partials       36       37       +1     
Files Changed Coverage Δ
readalongs/align.py 95.16% <77.77%> (-0.74%) ⬇️

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Speedy quick work - thanks @dhdaines !! I just tried this and it fixed the issue. I'll merge now.

@roedoejet roedoejet merged commit 9a526c2 into main Jul 25, 2023
4 of 6 checks passed
@roedoejet roedoejet deleted the dev.filler-words branch July 25, 2023 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants