fix: g2p main is about to be 2.0, but we still want 1.1 on Heroku #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had changed things so Heroku builds always took origin/main for g2p, but now that we're working on g2p 2.0 with breaking changes, we have to revert this change and get the latest g2p 1.1.* release instead. Fixes #186
Codecov Report
@@ Coverage Diff @@
## main #187 +/- ##
=======================================
Coverage 87.03% 87.03%
=======================================
Files 21 21
Lines 1735 1735
Branches 315 315
=======================================
Hits 1510 1510
Misses 188 188
Partials 37 37 |
roedoejet
approved these changes
Sep 11, 2023
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had changed things so Heroku builds always took origin/main for g2p, but now that we're working on g2p 2.0 with breaking changes, we have to revert this change and get the latest g2p 1.1.* release instead.
Fixes #186