Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscelaneous changes #193

Merged
merged 5 commits into from
Jan 5, 2024
Merged

Miscelaneous changes #193

merged 5 commits into from
Jan 5, 2024

Commits on Nov 1, 2023

  1. style: changes suggested by ruff but not reverted by black

    ruff is a drop-in replacement for black, flake8 and isort, but runs
    about 100 times faster.
    Ref: https://github.com/astral-sh/ruff
    
    On Studio, black accepts all the changes ruff makes.
    
    This commit applies what ruff did, and removed a superfluous command in
    test/run.py that ruff flagged, but does not change pre-commit or the dev
    dependencies yet.
    joanise committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9e0aeab View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. Configuration menu
    Copy the full SHA
    d114cc5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    baffdd4 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2024

  1. ci: measure and report CLI load time, and require subsecond

    Also, revert this commit:
     2023-09-13 acd724e Eric Joanis ci: suppress redundant tests runs on PR and push
    It turns out doing CI on review_requested is not great, because:
     - if you request 2 or 3 reviews, it triggers the action 2 or 3 times
     - when the branch needs a real merge, we do want the result of the merge
       tested in CI, so we lost important validation
    joanise committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    17868c3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2daf991 View commit details
    Browse the repository at this point in the history