Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lock numpy < 2 #195

Merged
merged 2 commits into from
Jan 22, 2024
Merged

lock numpy < 2 #195

merged 2 commits into from
Jan 22, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Jan 19, 2024

See: https://pythonspeed.com/articles/numpy-2

When numpy 2.0.0 is actually out, we'll want to test g2p and our other projects against it before allowing it.

Also fix the bold bug with coloredlogs, long ago fixed in g2p, which prevented us from updating it.

See: https://pythonspeed.com/articles/numpy-2

When numpy 2.0.0 is actually out, we'll want to test g2p and our other projects
against it before allowing it.
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4d5cf80) 87.04% compared to head (6c597b2) 87.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          21       21           
  Lines        1744     1744           
  Branches      315      315           
=======================================
  Hits         1518     1518           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

CLI load time: 0:00.34
Pull Request HEAD: 6c597b2a57ee717501fe9d00a43aec29574fd8d0
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:    242803 |     302946 | pkg_resources

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty @joanise !

@joanise joanise merged commit 53be622 into main Jan 22, 2024
6 checks passed
@joanise joanise deleted the dev.lock-numpy2 branch January 22, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants