Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump lxml to a version compatible with Python 3.11 on Windows #197

Merged
merged 2 commits into from
Jan 31, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Jan 31, 2024

This makes RAS properly compatible with Python 3.11 everywhere, although installation on Windows will require a compiler until the SoundSwallower wheels are published for 3.11 (see ReadAlongs/SoundSwallower#60)

Copy link
Contributor

CLI load time: 0:00.35
Pull Request HEAD: 7f1f47fe714e2a2b0ee659058341efc14a0a3f5d
Imports that take more than 0.1 s:
import time: self [us] | cumulative | imported package
import time:    262521 |     322151 | pkg_resources

Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53be622) 87.04% compared to head (7f1f47f) 87.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #197   +/-   ##
=======================================
  Coverage   87.04%   87.04%           
=======================================
  Files          21       21           
  Lines        1744     1744           
  Branches      315      315           
=======================================
  Hits         1518     1518           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@roedoejet roedoejet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks

@joanise joanise merged commit 9132b26 into main Jan 31, 2024
8 checks passed
@joanise joanise deleted the dev.bump-lxml branch January 31, 2024 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants