Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev.ej/web app docs #227

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Dev.ej/web app docs #227

merged 2 commits into from
Jul 10, 2024

Conversation

joanise
Copy link
Member

@joanise joanise commented Jul 8, 2024

PR Goal?

Add documentation for the ReadAlong Studio web app and web editor

Fixes?

This is part of ReadAlongs/Studio-Web#298

Feedback sought?

Read the documentation I wrote and let me know how you like it, if it should be improved, etc.

Priority?

this week if possible

Tests added?

n/a

How to test?

Serve locally:

git checkout dev.ej/web-app-docs
pip install -r docs/requirements.txt
mkdocs serve

and navigate to http://127.0.0.1:8000/web-app/

Or check it out pre-built at https://joanise.github.io/ReadAlong-Studio/dev/web-app/

Confidence?

medium

Version change?

no

Copy link

codecov bot commented Jul 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.23%. Comparing base (2e44e50) to head (d363d89).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #227   +/-   ##
=======================================
  Coverage   87.23%   87.23%           
=======================================
  Files          21       21           
  Lines        1770     1770           
  Branches      321      321           
=======================================
  Hits         1544     1544           
  Misses        189      189           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@deltork deltork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -25,12 +38,13 @@ Below is an example of a minimal implementation in a basic standalone html page.
<!-- Here is how you declare the Web Component -->
<read-along href="assets/sample.readalong" audio="assets/sample.wav"></read-along>
</body>

<!-- The last step needed is to import the package -->
<script type="module" src='https://unpkg.com/@readalongs/web-component@^1.4.0/dist/web-component/web-component.esm.js'</script>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.4.x

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^1.4.0 is the same as1.4.x, no?

@marctessier
Copy link
Collaborator

checked it out. Looks good Eric.

@joanise joanise merged commit a540b8c into main Jul 10, 2024
6 checks passed
@joanise joanise deleted the dev.ej/web-app-docs branch July 10, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants