-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev.ej/web app docs #227
Dev.ej/web app docs #227
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #227 +/- ##
=======================================
Coverage 87.23% 87.23%
=======================================
Files 21 21
Lines 1770 1770
Branches 321 321
=======================================
Hits 1544 1544
Misses 189 189
Partials 37 37 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@@ -25,12 +38,13 @@ Below is an example of a minimal implementation in a basic standalone html page. | |||
<!-- Here is how you declare the Web Component --> | |||
<read-along href="assets/sample.readalong" audio="assets/sample.wav"></read-along> | |||
</body> | |||
|
|||
<!-- The last step needed is to import the package --> | |||
<script type="module" src='https://unpkg.com/@readalongs/web-component@^1.4.0/dist/web-component/web-component.esm.js'</script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.4.x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^1.4.0
is the same as1.4.x
, no?
checked it out. Looks good Eric. |
PR Goal?
Add documentation for the ReadAlong Studio web app and web editor
Fixes?
This is part of ReadAlongs/Studio-Web#298
Feedback sought?
Read the documentation I wrote and let me know how you like it, if it should be improved, etc.
Priority?
this week if possible
Tests added?
n/a
How to test?
Serve locally:
and navigate to http://127.0.0.1:8000/web-app/
Or check it out pre-built at https://joanise.github.io/ReadAlong-Studio/dev/web-app/
Confidence?
medium
Version change?
no